Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an --offline option to run-fs.sh. #672

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

christian-oudard
Copy link
Contributor

Remove run-fs-offline.sh, which does not actually run offline.

Remove run-fs-offline.sh, which does not actually run offline.
Copy link
Contributor

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Base: 60.14% // Head: 60.14% // No change to project coverage 👍

Coverage data is based on head (0b44b1d) compared to base (ab83ad3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #672   +/-   ##
========================================
  Coverage    60.14%   60.14%           
========================================
  Files           85       85           
  Lines        11999    11999           
  Branches      1957     1957           
========================================
  Hits          7217     7217           
  Misses        3133     3133           
  Partials      1649     1649           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christian-oudard christian-oudard merged commit b189136 into develop Jan 24, 2023
@christian-oudard christian-oudard deleted the feature/improve_run-fs_offline branch January 24, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants